fix(shell): Add error handling, strict mode, and proper quoting to shell scripts #553
+44
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add set -euo pipefail for strict error handling
- Quote $1 in command -v to prevent word splitting
- Quote $@ to preserve argument boundaries
- Fix regex pattern: use ${HOME} with proper quoting
- Quote $REMOTE_PODMAN in arithmetic comparison
- Add fallback for REMOTE_PODMAN if command fails
- Use ${VAR:-} syntax for unset variable checks with set -u
- Add error handling for podman --version command
- Convert PODMAN_ARGS, PKI_HOST_MOUNT_ARGS, EXTRA_ARGS to arrays for shellcheck compliance
- Add set -euo pipefail for strict error handling
- Quote all variable references ($KUBECONFIG, $KUBECONFIG_EDGE, $WORKSPACE)
- Use ${VAR:-} syntax for unset variable checks with set -u
- Use mktemp -d instead of /tmp for secure temporary directory
- Tests will now fail fast on any error instead of continuing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
set -euo pipefailfor strict error handlingmktempfor secure temporary directoriesChanges
pattern.sh
set -euo pipefailat script start"$1","$@", and other variable expansionsPODMAN_ARGS,PKI_HOST_MOUNT_ARGS,EXTRA_ARGSto bash arrays"${ARRAY[@]}"syntax for proper array expansionrun_tests.sh
set -euo pipefailat script start"$KUBECONFIG"and other variablesmktemp -dinstead of hardcoded/tmppathsWORKSPACEwith${WORKSPACE:-}syntaxTest Plan
shellcheck pattern.sh- should pass with no warningsshellcheck tests/interop/run_tests.sh- should passFixes #522
Fixes #523
Fixes #524
Fixes #525
Fixes #526
Fixes #527
Fixes #528
Fixes #529
Fixes #530